[#2620] feat(spark-connector): support hive table format properties#2605
Merged
jerryshao merged 11 commits intoapache:mainfrom Mar 29, 2024
Merged
[#2620] feat(spark-connector): support hive table format properties#2605jerryshao merged 11 commits intoapache:mainfrom
jerryshao merged 11 commits intoapache:mainfrom
Conversation
FANNG1
force-pushed
the
properties
branch
3 times, most recently
from
bc0e4cb to
b485ac4
Compare
FANNG1
changed the title
Contributor
Author
|
It's ready to review now, @jerryshao @qqqttt123 @mchades @yuqi1129 @diqiu50 please help to review when you are free. |
diqiu50
reviewed
Mar 25, 2024
...tor/src/main/java/com/datastrato/gravitino/spark/connector/hive/HivePropertiesConverter.java
Show resolved
Hide resolved
diqiu50
reviewed
Mar 25, 2024
...tor/src/main/java/com/datastrato/gravitino/spark/connector/hive/HivePropertiesConverter.java
Outdated
Show resolved
Hide resolved
diqiu50
reviewed
Mar 25, 2024
spark-connector/src/main/java/com/datastrato/gravitino/spark/connector/PropertiesConverter.java
Outdated
Show resolved
Hide resolved
yuqi1129
reviewed
Mar 25, 2024
...tor/src/main/java/com/datastrato/gravitino/spark/connector/hive/HivePropertiesConverter.java
Show resolved
Hide resolved
...tor/src/main/java/com/datastrato/gravitino/spark/connector/hive/HivePropertiesConverter.java
Outdated
Show resolved
Hide resolved
mchades
reviewed
Mar 26, 2024
...tor/src/main/java/com/datastrato/gravitino/spark/connector/hive/HivePropertiesConverter.java
Outdated
Show resolved
Hide resolved
...rc/test/java/com/datastrato/gravitino/integration/test/util/spark/SparkTableInfoChecker.java
Show resolved
Hide resolved
...tor/src/main/java/com/datastrato/gravitino/spark/connector/hive/HivePropertiesConverter.java
Show resolved
Hide resolved
Contributor
Author
Contributor
Author
|
@yuqi1129 @mchades @diqiu50 ,is there any other comments? @jerryshao do you have time to review? |
Contributor
|
Overall LGTM |
Contributor
Author
|
@jerryshao do you have time to review this PR? |
jerryshao
reviewed
Mar 29, 2024
Comment on lines
+31
to
+34
| public static final String SPARK_HIVE_STORED_AS = "hive.stored-as"; | ||
| public static final String SPARK_HIVE_INPUT_FORMAT = "input-format"; | ||
| public static final String SPARK_HIVE_OUTPUT_FORMAT = "output-format"; | ||
| public static final String SPARK_HIVE_SERDE_LIB = "serde-lib"; |
Contributor
There was a problem hiding this comment.
Are these configurations defined by Spark or by you?
Contributor
Author
There was a problem hiding this comment.
spark use raw string like hive.stored-as, I defined SPARK_HIVE_STORED_AS to refer to it.
jerryshao
reviewed
Mar 29, 2024
| HivePropertiesConstants.GRAVITINO_HIVE_SERDE_LIB); | ||
|
|
||
| /** | ||
| * CREATE TABLE xxx STORED AS PARQUET will save "hive.stored.as" = "PARQUET" in property. |
Contributor
There was a problem hiding this comment.
Is it "hive.stored-as" or "hive.stored.as"?
Contributor
Author
There was a problem hiding this comment.
hive.stored-as, will correct it
Contributor
Author
|
@jerryshao all comments are addressed, please help to review again |
jerryshao
approved these changes
Mar 29, 2024
Contributor
|
LGTM. Thanks @FANNG1 for your work. |
Contributor
|
Sorry, I've dealt with some things during this time. Have you completed this part of the work? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
support hive table format properties
Why are the changes needed?
Fix: #2620
Does this PR introduce any user-facing change?
no
How was this patch tested?
UT and IT